disallow empty header names #1690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azat
reviewed
Jul 9, 2024
Member
azat
left a comment
azat
left a comment
There was a problem hiding this comment.
LGTM but can you please also add a test
Contributor
Author
|
Slightly busy nowadays, so I may postpone adding a test for a certain number of days. But yes, once I got the opportunity, I'll try. Suggestion: add a label "needs a test" to pull requests missing a test. |
Contributor
Author
|
Test added in 270fb06. |
azat
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1686
In theory, we could be more strict, since there is only a subset of allowed characters:
But I'd skip such verification, unless there is a legitimate interest (versus performances).