Skip to content

evsig_base is thread unsafe #779

@htuch

Description

@htuch

This is another shared variable (as encountered in #777) that TSAN flags as being problematic. This is because the signal handler can run on any thread. See envoyproxy/envoy#6083 for a backtrace.

We have an internal patch to make this atomic. If folks agree that it's sufficient to resolve this and #777 by switching to atomics, I'm happy to submit a PR to resolve both issues.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions