Skip to content

TMP: Pin setuptools_scm<8 - #115

Merged
avalentino merged 2 commits into
liberfa:masterfrom
pllim:fix-setuptools-scm
Sep 20, 2023
Merged

avalentino merged 2 commits into
liberfa:masterfrom
pllim:fix-setuptools-scm

Conversation

@pllim

@pllim pllim commented Sep 20, 2023 •

Copy link
Copy Markdown
Contributor

Until compatibility with setuptools_scm 8 can be fixed properly (#116).

@pllim

pllim commented Sep 20, 2023

Copy link
Copy Markdown
Contributor Author

@avalentino , any chance this can get merged soon to unblock astropy testing? Thanks!

@avalentino avalentino added the dependencies Pull requests that update a dependency file label Sep 20, 2023
@avalentino

Copy link
Copy Markdown
Member

Thanks a lot @pllim

@avalentino , any chance this can get merged soon to unblock astropy testing? Thanks!

I have approved the PR but it is still in DRAFT.
Please change the status to "Ready for review" or just confirm that it is OK if I do it myself

@pllim
pllim marked this pull request as ready for review September 20, 2023 17:24
@pllim

pllim commented Sep 20, 2023

Copy link
Copy Markdown
Contributor Author

Ooops. Done. Thanks!

@avalentino
avalentino merged commit b6a7b21 into liberfa:master Sep 20, 2023
@pllim
pllim deleted the fix-setuptools-scm branch September 20, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants