Repository navigation
Add Python 3.12 job and wheels - #111
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
Ah... maybe because numpy 1.25 does not have a cp312 wheel, so it is trying to build numpy from source before building pyerfa... |
like scipy
|
Not sure if you want all of this. If not, feel free to pick and choose. At least it is all green now. |
There was a problem hiding this comment.
@mhvk , turns out at the very least, I need the changes in this file for astropy/astropy#14784
|
Can one of the maintainers help me push this forward one way or another? Thanks! Python 3.12rc2 is out. |
mhvk
left a comment
mhvk
left a comment
There was a problem hiding this comment.
This looks good to me and everything is green, but I feel super uncomfortable approving something I don't understand, so let me ping @astrofrog and @avalentino, hoping that they are better versed in wheel creation...
| "setuptools", | ||
| "setuptools_scm>=6.2", | ||
| "jinja2>=2.10.3", | ||
| "numpy>=1.25,<2; python_version<='3.11'", |
There was a problem hiding this comment.
Should we use <3.12 to be the exact opposite of >=3.12?
There was a problem hiding this comment.
Wondering how 3.11.3 evaluates for example, is it <=3.11?
There was a problem hiding this comment.
Will that pick up 3.12rc? I can never tell how these operators work.
There was a problem hiding this comment.
There was a problem hiding this comment.
Well, I made the change you requested and CI is still green, so I guess it is okay after all. Please re-review. Thanks!
|
OK, let's get it in. Thanks, @pllim! |
|
Thanks, all! |
pyerfa won't build nicely in astropy/astropy#14784 even after #107 and I don't know why.
Fix #108 maybe
Blocked by:
Questions: