Repository navigation
Update ERFA to SOFA 20200721. - #71
Conversation
|
@mhvk please note that there is a typo in the README.rst section "Version information": should be |
|
|
||
| ## SOFA version, update if needed in new relases | ||
| AC_DEFINE([SOFA_VERSION], ["20190722"], [Define to the version of SOFA]) | ||
| AC_DEFINE([SOFA_VERSION], ["20200721"], [Define to the version of SOFA]) |
There was a problem hiding this comment.
I think you should also bump the version number (few lines above) to "1.8.0".
Is it correct?
There was a problem hiding this comment.
Yes, absolutely right, but supposedly this is done in the next step, of actually preparing a release... (I'm trying to follow RELEASE.txt)
There was a problem hiding this comment.
ups, sorry.
I didn't read RELEASE.txt before writing.
|
@avalentino - thanks! Fix in |
f6b9a9f to
cea6eb3
Compare
|
Actually, reading |
|
OK, just too annoying to try to do the numbering in two branches - now adjusted the erfa version number as well as the shared library number here. @eteq - could you please check my understanding of the erfa numbering is correct? SOFA only has bug fixes. |
yes, you are right @mhvk |
|
@eteq - do you want to check the version numbering before I merge this? |
|
The version number (1.7.1) seems OK to me |
|
OK, @sergiopasra, thanks for the cross-check. I'll merge now! |
fixes #70, #66
Only small changes in SOFA.
I couldn't resist just putting in erfa version 1.8.0 instead of x.y.z, since I'd hope to go ahead and do a release too.