New version of SOFA #34

Activity

1. eteq commented on May 12, 2016

   

   eteq

   on May 12, 2016

   Member

   More actions

   Oh, interesting - from the astropy perspective, this is definitely useful, both for ecliptic and the new long-term precession models (which we probably want to support somehow, but will want to consider carefully how best to do so).
2. phn commented on May 17, 2016

   

   phn

   on May 17, 2016

   Contributor

   More actions

   Hello,

   I have updated erfa to use sofa 20160503. The code is at https://github.com/phn/erfa/tree/sofac20160503.

   I followed the steps in RELEASE.rst; upto and including the "make distcheck" step. I think the steps after that are to be followed in the liberfa/erfa repository.

   I had to edit the file src/Makefile.am to include the new files added by SOFA. (See http://www.iausofa.org/current_changes.html). This step is not mentioned in RELEASE.rst and so I have added it.

   If this is acceptable, should I raised a new pull request or is there a way to attach my branch to this issue?

   Regards,
   Prasanth
3. eteq commented on May 17, 2016

   

   eteq

   on May 17, 2016

   Member

   More actions

   Awesome, thanks @phn! Use a separate pull request, and just be sure to put "closes #34" in the description. That way merging the PR will close this issue.
4. phn commented on May 17, 2016

   

   phn

   on May 17, 2016

   Contributor

   More actions

   Hello,

   Ok done. New issue is #35 .

   Regards,
   Prasanth
5. eteq

   closed this as completedin #35on Sep 1, 2016