fix(block::check) fix dead code on verification of empty block#1829
Merged
Conversation
The is_empty() verification inside the check() function was never reached, since it was inside an if condition that failed for empty blocks, so check() never actually signaled empty block
KY-U
force-pushed
the
2026-05-fix-check-dead-code
branch
from
32735c1 to
49d7bdd
Compare
Member
|
That’s more than dead code, thanks! This is the offending commit. |
Member
|
Thanks also for adding the test. Completing full unit test coverage for chain and machine objects is part of the release checklist. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
is_empty()verification inside thecheck()function can never betrue, since it is nested inside theif (is_first_non_coinbase())condition, that fails for empty blocks, socheck()never actually signaled on an empty block.