Support connection service file and service names#868
Closed
feikesteenbergen wants to merge 1 commit intolib:masterfrom
Closed
Support connection service file and service names#868feikesteenbergen wants to merge 1 commit intolib:masterfrom
feikesteenbergen wants to merge 1 commit intolib:masterfrom
Conversation
feikesteenbergen
force-pushed
the
use_service_file
branch
from
b1b6063 to
36e7fd7
Compare
feikesteenbergen
force-pushed
the
use_service_file
branch
from
36e7fd7 to
51906d9
Compare
feikesteenbergen
force-pushed
the
use_service_file
branch
from
51906d9 to
c63bf70
Compare
feikesteenbergen
force-pushed
the
use_service_file
branch
from
c63bf70 to
17d418b
Compare
feikesteenbergen
force-pushed
the
use_service_file
branch
from
17d418b to
a30c0ae
Compare
The whole point of supporting this can best be said by directly quoting the PostgreSQL manual: > The connection service file allows libpq connection parameters to be > associated with a single service name. That service name can then be > specified by a libpq connection, and the associated settings will be > used. This allows connection parameters to be modified without > requiring a recompile of the libpq application. The service name can > also be specified using the PGSERVICE environment variable. source: https://www.postgresql.org/docs/current/libpq-pgservice.html Fixes lib#538
feikesteenbergen
force-pushed
the
use_service_file
branch
from
a30c0ae to
8750518
Compare
|
@rafiss ping on this PR? Seems pretty decent. The alternative today is to use something like this, which I have to admit is pretty gross... https://github.com/behrang/go-pgservice |
arp242
added a commit
that referenced
this pull request
Mar 17, 2026
Allow reading connection from a service file if "service=name" is used. Based on #868 Co-authored-by: Feike Steenbergen <[email protected]> Fixes #538 Closes #868
arp242
added a commit
that referenced
this pull request
Mar 17, 2026
Allow reading connection from a service file if "service=name" is used. Based on #868 Co-authored-by: Feike Steenbergen <[email protected]> Fixes #538 Closes #868
arp242
added a commit
that referenced
this pull request
Mar 17, 2026
Allow reading connection from a service file if "service=name" is used. Based on #868 Co-authored-by: Feike Steenbergen <[email protected]> Fixes #538 Closes #868
arp242
added a commit
that referenced
this pull request
Mar 17, 2026
Allow reading connection from a service file if "service=name" is used. Based on #868 Co-authored-by: Feike Steenbergen <[email protected]> Fixes #538 Closes #868
Collaborator
|
Merged via #1285, as re-implementing this from scratch was easier than solving the conflicts on this 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The whole point of supporting this can best be said by directly quoting
the PostgreSQL manual:
source: https://www.postgresql.org/docs/current/libpq-pgservice.html
Fixes #538