fix: pqutil: separate Home() and PostgresqlHome()#1295
Closed
mxmCherry wants to merge 2 commits intolib:masterfrom
Closed
fix: pqutil: separate Home() and PostgresqlHome()#1295mxmCherry wants to merge 2 commits intolib:masterfrom
mxmCherry wants to merge 2 commits intolib:masterfrom
Conversation
mxmCherry
commented
Mar 26, 2026
| // Home gets the PostgreSQL configuration dir in the user's home directory: | ||
| // %APPDATA%/postgresql on Windows, and $HOME/.postgresql/postgresql.crt | ||
| // everywhere else. | ||
| // %APPDATA%/postgresql on Windows, and $HOME everywhere else. |
Author
There was a problem hiding this comment.
This logic is what actually matches the postgres pqGetHomeDirectory: https://github.com/postgres/postgres/blob/2b117bb/src/interfaces/libpq/fe-connect.c#L8214
- On Unix, this actually returns the user's home directory. On Windows
- it returns the PostgreSQL-specific application data folder.
Collaborator
|
Thanks; fixed via #1300 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address #1294
Decided that the
.../.postgresqldir is quite special (and rarely used, only for certs in this project) so decided it deserves a separate helper.Sorry, did not bother figuring out how to run tests locally, relying on CI.Tests are passing locally. Looks like Home() helper itself is not tested at all, so did not add PostgresqlHome() tests as well.Pls review carefully.