Conversation
Closed
arp242
force-pushed
the
pqerror
branch
3 times, most recently
from
3758a44 to
fe62098
Compare
Add a pqerror package with a list of error codes. Typical usage might be
something like:
pqErr, ok := errors.AsType[*pq.Error](err)
if ok && pqErr == pqerror.UniqueViolation {
return fmt.Errorf("user already exists")
}
To make this a bit more convenient, it also adds a pqerror.As()
function:
pqErr := pqerror.As(err, pqerror.UniqueViolation)
if pqErr != nil {
log.Fatalf("email %q already exsts", email)
}
if err != nil {
return err
}
This also moves most of the error stuff to the pqerror package, with
type aliases in the pq package so it won't break anything. Has to export
Error.Query to make this work, which is okay. Keep most of the tests in
the main pq package for now, to ensure this works.
Fixes #492
Still move pq.ErrorCode and pq.ErrorClass to pqerror.Code and pqerror.Class, so we can use it in pqerror. Also move the error severity values here. Seems to make sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a pqerror package with a list of error codes. Typical usage might be something like:
To make this a bit more convenient, it also adds a pqerror.As() function:
This also moves most of the error stuff to the pqerror package, with type aliases in the pq package so it won't break anything. Has to export Error.Query to make this work, which is okay. Keep most of the tests in the main pq package for now, to ensure this works.
Fixes #492