Fix SSL key permission check to allow modes stricter than 0600/0640#1265
Merged
arp242 merged 2 commits intolib:masterfrom Mar 9, 2026
Merged
Fix SSL key permission check to allow modes stricter than 0600/0640#1265arp242 merged 2 commits intolib:masterfrom
arp242 merged 2 commits intolib:masterfrom
Conversation
The permission check used XOR (^) which only accepted an exact mode match. Modes more restrictive than the maximum (e.g. 0400) were incorrectly rejected. Use AND NOT (&^) to check that no bits exceed the allowed maximum instead. Fixes lib#1257
arp242
force-pushed
the
fix-ssl-key-permission-check
branch
from
b18e797 to
8be4559
Compare
arp242
force-pushed
the
fix-ssl-key-permission-check
branch
from
8be4559 to
2acc8ae
Compare
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The permission check in
checkPermissionsused XOR (^) which only acceptedan exact mode match (0600 for user-owned, 0640 for root-owned). Modes more
restrictive than the maximum (e.g. 0400, read-only) were incorrectly rejected.
Use AND NOT (
&^) to check that no permission bits exceed the allowed maximuminstead.
Fixes #1257