Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: lib/pq
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.11.1
Choose a base ref
...
head repository: lib/pq
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.11.2
Choose a head ref
  • 2 commits
  • 4 files changed
  • 2 contributors

Commits on Feb 10, 2026

  1. Don't send dbname= as a startup parameter when database= is used 

    Fixes #1256
    @arp242
    arp242 committed Feb 10, 2026
    Configuration menu
    Copy the full SHA
    0c529db View commit details
    Browse the repository at this point in the history

  2. Don't send empty startup parameters 

    That's also what libpq does; from src/interfaces/libpq/fe-protocol3.c

	if (conn->pguser && conn->pguser[0])
		ADD_STARTUP_OPTION("user", conn->pguser);
	if (conn->dbName && conn->dbName[0])
		ADD_STARTUP_OPTION("database", conn->dbName);
	if (conn->replication && conn->replication[0])
		ADD_STARTUP_OPTION("replication", conn->replication);
	if (conn->pgoptions && conn->pgoptions[0])
		ADD_STARTUP_OPTION("options", conn->pgoptions);
	if (conn->send_appname) {
		/* Use appname if present, otherwise use fallback */
		val = conn->appname ? conn->appname : conn->fbappname;
		if (val && val[0])
			ADD_STARTUP_OPTION("application_name", val);
	}
	if (conn->client_encoding_initial && conn->client_encoding_initial[0])
		ADD_STARTUP_OPTION("client_encoding", conn->client_encoding_initial);

Sending an empty value works for most systems, but not in Supavisor due
to a bug there. Easy enough to fix here, so why not.

Fixes #1259

Co-authored-by: Martin Tournoij <[email protected]>
    @dossy @arp242
    dossy and arp242 committed Feb 10, 2026
    Configuration menu
    Copy the full SHA
    1412805 View commit details
    Browse the repository at this point in the history
Loading