Conversation
ubaidsk
force-pushed
the
fix_ci_node_tests_failure
branch
from
19192fe to
225fcd2
Compare
ubaidsk
force-pushed
the
fix_ci_node_tests_failure
branch
from
225fcd2 to
1292f28
Compare
|
It seems some checks are being cancelled at the CI. I am unsure what is causing them to cancel. Is there some limit on the GitHub CI jobs? Did we exhaust some limit (in case it exists)? |
| if (HAVE_BUILD_TO_WASM) | ||
| set(WASM_COMPILE_FLAGS "-g0 -fexceptions") | ||
| set(WASM_LINK_FLAGS | ||
| "-Oz -g0 -fexceptions -Wall -Wextra -s ASSERTIONS -s ALLOW_MEMORY_GROWTH=1 -s WASM_BIGINT" |
There was a problem hiding this comment.
Providing -Oz seems to fix the issue. Other flags are provided just to be extra-safe. I think -Oz is more for reducing the size of the generated file. Thus, I am unsure how it fixes the memory utilization. I also experienced this similar behaviour of high memory usage when -Oz is not provided to lfortran while pursuing #658.
|
Jobs at the CI are getting cancelled (for some reason). The CI passed in the 3rd attempt. This is ready. |
certik
left a comment
certik
left a comment
There was a problem hiding this comment.
I think this is good!
Thanks @Shaikh-Ubaid for this. Let's merge it and see if this helps.
|
I've seen the Windows build being canceled a lot on my PR as well. Maybe the GitHub Actions are unstable today. |
2 participants
fixes #1790