You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit e8fcde7
Browse filesBrowse the repository at this point in the historyBrowse files
[wasi] Correct CoreCLR-WASI smoke leg known-blocker note
The interp smoke blocker was the nested-type reverse-thunk key mismatch (dotnet#130739),
not the cold portable-entry-point timing (dotnet#130634). The leg needs the per-app relink
for thunk coverage; dotnet#130634 only affects a future R2R-enabled leg.
Co-authored-by: Copilot App <[email protected]>
Copilot-Session: ea71f7e7-5477-4e58-bf1a-ca27d4b23d74
Copy file name to clipboardExpand all lines: eng/pipelines/common/templates/wasi-wasm-coreclr-library-tests.yml
+6-4Lines changed: 6 additions & 4 deletions
Original file line number
Diff line number
Diff line change
@@ -18,10 +18,12 @@ jobs:
18
18
# with the WasmTestOnWasmtime scenario and the wasi_wasm helix queue.
19
19
# See https://github.com/dotnet/runtime/issues/130129.
20
20
#
21
-
# Bring-up leg: smoke-only and non-gating (rolling alwaysRun). It is expected to remain
22
-
# red until the CoreCLR-WASI cold portable-entry-point signature-mismatch fix lands
23
-
# (https://github.com/dotnet/runtime/issues/130634); any test that formats an exception
24
-
# message or hits cold globalization/reflection traps in the interpreter until then.
21
+
# Bring-up leg: smoke-only and non-gating (rolling alwaysRun). It stays red until the
22
+
# per-app native relink lands (so a test's own [UnmanagedCallersOnly] reverse thunks are
23
+
# generated + linked into corerun); see https://github.com/dotnet/runtime/issues/130129.
24
+
# With the relink + the nested-type thunk-key fix (dotnet/runtime#130739), the interpreter
25
+
# runs the suite. #130634 (cold portable-entry-point publication) only affects a future
26
+
# R2R-enabled leg, not this pure-interpreter smoke.
0 commit comments