Repository navigation
[pull] main from NVIDIA:main - #85
Merged
Merged
Conversation
* feat(llm): add compact prompt line numbering Signed-off-by: Deepak Jain <[email protected]> * fix(llm): trim compact prompt env value, document option, pin contract Address rng1995 reviews on #542 (2026-09-16, 2026-09-18): normalize SKILLSPECTOR_COMPACT_PROMPTS with .strip().lower() matching the existing provider/SSL env parsers, document the option/default/truthy values in the README environment-variable table, and extend the focused test to pin the unset/default path plus normalized truthy inputs. Signed-off-by: Deepak Jain <[email protected]> --------- Signed-off-by: Deepak Jain <[email protected]>
* fix(patterns): detect literal XOR decoded commands Signed-off-by: Deepak Jain <[email protected]> * fix(patterns): preserve shared Python AST cache Signed-off-by: Deepak Jain <[email protected]> * style(patterns): format XOR command resolver Signed-off-by: Deepak Jain <[email protected]> * fix(patterns): bound malformed XOR decoder inputs Signed-off-by: Deepak Jain <[email protected]> * style(patterns): apply repository formatter Signed-off-by: Deepak Jain <[email protected]> * style(patterns): apply repository formatter Signed-off-by: Deepak Jain <[email protected]> * fix(patterns): use logical line starts for XOR-decoded SC2 context _decoded_literal_xor_calls reports line numbers via get_line_number, which counts logical separators (CR, form feed, U+2028/U+2029), but the SC2 call site indexed context with LF-only line offsets. A leading comment containing U+2028 separators pushed line_num past the LF-offset array, raising IndexError and dropping every supply-chain finding for the file. Index the context on the existing logical_line_starts offsets instead, consistent with the decoder. Add a mixed-file regression test with two U+2028 characters in a leading comment, an independent plaintext SC2 match, and the XOR fixture last, asserting both SC2 findings survive with correct line numbers. Signed-off-by: Deepak Jain <[email protected]> --------- Signed-off-by: Deepak Jain <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )