Repository navigation
Commit 0521d82
committed
fix(514): search a re-exported module once per name, not once per walk
The barrel walker kept a visited set of file QNs. A barrel with both
`export * from './m'` and `export { a as b } from './m'` searched m for
`b` through the star edge first, marked m visited, and then skipped m
when the renamed edge asked for `a`. The call to `b` got no edge.
The visited set is now keyed on (file QN, name). Each key is an owned
string stored as its own value and freed with the table.
Tested: new lrp_ts_barrel_star_and_renamed_same_module fails before
(renamed=0) and passes after.
Suites extraction_imports, edge_imports, path_alias, mcp,
lsp_resolution_probe: 622 passed, 4 skipped.
Signed-off-by: chidev <[email protected]>1 parent cf70a88 commit 0521d82
2 files changed
Lines changed: 61 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1468 | 1468 | | |
1469 | 1469 | | |
1470 | 1470 | | |
1471 | | - | |
| 1471 | + | |
| 1472 | + | |
| 1473 | + | |
| 1474 | + | |
| 1475 | + | |
| 1476 | + | |
| 1477 | + | |
| 1478 | + | |
| 1479 | + | |
| 1480 | + | |
| 1481 | + | |
| 1482 | + | |
| 1483 | + | |
1472 | 1484 | | |
1473 | 1485 | | |
1474 | 1486 | | |
| |||
1501 | 1513 | | |
1502 | 1514 | | |
1503 | 1515 | | |
1504 | | - | |
| 1516 | + | |
| 1517 | + | |
| 1518 | + | |
| 1519 | + | |
| 1520 | + | |
| 1521 | + | |
| 1522 | + | |
| 1523 | + | |
| 1524 | + | |
| 1525 | + | |
| 1526 | + | |
| 1527 | + | |
| 1528 | + | |
| 1529 | + | |
| 1530 | + | |
1505 | 1531 | | |
1506 | 1532 | | |
1507 | | - | |
| 1533 | + | |
1508 | 1534 | | |
1509 | 1535 | | |
1510 | 1536 | | |
| |||
1710 | 1736 | | |
1711 | 1737 | | |
1712 | 1738 | | |
1713 | | - | |
| 1739 | + | |
1714 | 1740 | | |
1715 | 1741 | | |
1716 | 1742 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1385 | 1385 | | |
1386 | 1386 | | |
1387 | 1387 | | |
| 1388 | + | |
| 1389 | + | |
| 1390 | + | |
| 1391 | + | |
| 1392 | + | |
| 1393 | + | |
| 1394 | + | |
| 1395 | + | |
| 1396 | + | |
| 1397 | + | |
| 1398 | + | |
| 1399 | + | |
| 1400 | + | |
| 1401 | + | |
| 1402 | + | |
| 1403 | + | |
| 1404 | + | |
| 1405 | + | |
| 1406 | + | |
| 1407 | + | |
| 1408 | + | |
| 1409 | + | |
| 1410 | + | |
| 1411 | + | |
| 1412 | + | |
| 1413 | + | |
| 1414 | + | |
| 1415 | + | |
| 1416 | + | |
| 1417 | + | |
1388 | 1418 | | |
1389 | 1419 | | |
1390 | 1420 | | |
| |||
2033 | 2063 | | |
2034 | 2064 | | |
2035 | 2065 | | |
| 2066 | + | |
2036 | 2067 | | |
2037 | 2068 | | |
2038 | 2069 | | |
| |||
0 commit comments