Ceremony: allow CRL ceremonies to skip certain lints#8368
Merged
aarongable merged 2 commits intomainfrom Aug 22, 2025
Merged
Conversation
Contributor
|
Skipping lints seems like a reasonable feature. For that zlint issue though, do we want to configure the lint instead of ignoring it? It seems like adding support for lint configuration that might be even more useful for solving this particular issue |
Contributor
Author
|
Making lints configurable is a much larger change which will affect the whole //linter package, and therefore our prod issuance as well, not just the ceremony tool. I think the simpler route is better for now. Also, we have this specific check hardcoded in the ceremony tool already: Lines 33 to 37 in 513e113 |
beautifulentropy
approved these changes
Aug 22, 2025
jprenken
approved these changes
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zlint has added more lints, some of which (like zmap/zlint#916) are insufficiently smart and can't tell the difference between a Subscriber CRL and a Root CRL. We need the ability to skip lints like this, so give the CRL ceremony the same capability as we already have for our various certificate ceremonies.