Repository navigation
Conversation
zhijie-yang
commented
Jan 16, 2025
zhijie-yang
commented
- Have you signed the CLA?
letFunny
requested changes
Jan 17, 2025
letFunny
left a comment
letFunny
left a comment
Owner
There was a problem hiding this comment.
Thanks for this James, it looks very good. My comments are mainly about the tests, there are a couple suggestions for error messages but I don't have a strong opinion on those.
letFunny
force-pushed
the
main
branch
9 times, most recently
from
January 21, 2025 12:17
493d553 to
717fecd
Compare
Co-authored-by: Alberto Carretero <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.