Skip to content

Conversation

@rth
Copy link
Collaborator

@rth rth commented Oct 14, 2022

Related #1

Edit: close #1 since this is now building scikit-learn from main.

@rth
Copy link
Collaborator Author

rth commented Oct 14, 2022

OK, yes, so indeed the Pyodide venv currently doesn't work with scipy due to pyodide/pyodide#3186 I think.

This successfully builds the wheel for 1.1.1 , but that's not very useful since we are for now not loading it in the included test scripts (and it's the same version anyway as the one shipped by Pyodide 0.22.0a1).

For scikit-learn main branch, there is some regression with omp.h include that fails to cross-compile.

Byt anyway I agree that the first step could be looking into fixing tests for 1.1.1. I think some number of the failures would be due to pyodide/pyodide#156

@lesteve
Copy link
Owner

lesteve commented Oct 25, 2022

I'll merge this one when CI is green, this is good enough to be useful.

Possible improvements:

  • right now the exit code of the pytest command is not used so the CI will be green as long as pyodide build works
  • improve run-tests-by-module.sh:
    • some test modules can be marked as xfail, others should be passing. We should use pytest exit code for this
    • post a summary at the end of the logs of which module failed
  • right now scikit-learn-pytest.js installs the wheel in dist/scikit_learn-1.2.dev0-cp310-cp310-emscripten_3_1_21_wasm32.whl. There is probably a way to not hardcode its name.
  • turn problems noted in README.md to dedicated github issues

@lesteve lesteve merged commit e815756 into lesteve:main Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Building from source for development

2 participants