Skip to content

chore(deps): test useNx with lower version of Nx#563

Merged
ghiscoding merged 3 commits intonextfrom
chore/use-nx-lower-version
Apr 13, 2023
Merged

chore(deps): test useNx with lower version of Nx#563
ghiscoding merged 3 commits intonextfrom
chore/use-nx-lower-version

Conversation

@ghiscoding
Copy link
Copy Markdown
Member

Description

lower Nx version used for optional useNx option with lerna run

Motivation and Context

newer Nx versions seems to cause more console warnings and we don't really need to test higher versions since using Nx with lerna run is totally optional anyway

How Has This Been Tested?

Types of changes

  • Chore (change that has absolutely no effect on users)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 13, 2023

Codecov Report

❗ No coverage uploaded for pull request base (next@5c4ee48). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next     #563   +/-   ##
=======================================
  Coverage        ?   97.92%           
=======================================
  Files           ?      160           
  Lines           ?    12424           
  Branches        ?     2027           
=======================================
  Hits            ?    12165           
  Misses          ?      258           
  Partials        ?        1           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit 3085270 into next Apr 13, 2023
@ghiscoding ghiscoding deleted the chore/use-nx-lower-version branch April 13, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant