Skip to content

feat(run)!: remove --use-nx (powered by Nx) option from run command#554

Merged
ghiscoding merged 2 commits intonextfrom
feat/remove-run-with-nx
Apr 7, 2023
Merged

feat(run)!: remove --use-nx (powered by Nx) option from run command#554
ghiscoding merged 2 commits intonextfrom
feat/remove-run-with-nx

Conversation

@ghiscoding
Copy link
Copy Markdown
Member

@ghiscoding ghiscoding commented Apr 7, 2023

Description

Remove unused useNx (Powered by Nx) option from the run command.

Motivation and Context

I don't think any users were using this option, since whoever wants to use Nx will probably want to use Lerna directly since Lerna is now requiring Nx. So this is a Breaking Change to make the run command lighter and keep Lerna-Lite... lite

How Has This Been Tested?

Types of changes

  • Chore (change that has absolutely no effect on users)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have removed tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2023

Codecov Report

❗ No coverage uploaded for pull request base (next@1baa0d1). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next     #554   +/-   ##
=======================================
  Coverage        ?   97.97%           
=======================================
  Files           ?      160           
  Lines           ?    12236           
  Branches        ?     1998           
=======================================
  Hits            ?    11987           
  Misses          ?      248           
  Partials        ?        1           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit b5ff9c9 into next Apr 7, 2023
@ghiscoding ghiscoding deleted the feat/remove-run-with-nx branch April 7, 2023 02:31
ghiscoding added a commit that referenced this pull request Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant