Skip to content

feat(cli): remove listable dependency from CLI#553

Merged
ghiscoding merged 1 commit intonextfrom
chore/cli-listable-standalone
Apr 7, 2023
Merged

feat(cli): remove listable dependency from CLI#553
ghiscoding merged 1 commit intonextfrom
chore/cli-listable-standalone

Conversation

@ghiscoding
Copy link
Copy Markdown
Member

Description

CLI had a dependency on listable only to get a list of CLI listable options and an interface, we can easily remove this to keep CLI small

Motivation and Context

keep CLI small without dependencies (except the core deps)

How Has This Been Tested?

Types of changes

  • Chore (change that has absolutely no effect on users)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 7, 2023

Codecov Report

❗ No coverage uploaded for pull request base (next@1758c3b). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next     #553   +/-   ##
=======================================
  Coverage        ?   97.65%           
=======================================
  Files           ?      160           
  Lines           ?    12424           
  Branches        ?     2017           
=======================================
  Hits            ?    12132           
  Misses          ?      291           
  Partials        ?        1           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit 1baa0d1 into next Apr 7, 2023
@ghiscoding ghiscoding deleted the chore/cli-listable-standalone branch April 7, 2023 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant