Skip to content

feat(publish)!: make version & publish commands optionnal, closes #450#552

Merged
ghiscoding merged 4 commits intonextfrom
feat/optional-version-publish
Apr 6, 2023
Merged

feat(publish)!: make version & publish commands optionnal, closes #450#552
ghiscoding merged 4 commits intonextfrom
feat/optional-version-publish

Conversation

@ghiscoding
Copy link
Copy Markdown
Member

@ghiscoding ghiscoding commented Apr 6, 2023

Description

Make version and publish as optional commands. This change will in summary turn every command of the lib as optional commands (except init which is a tiny command) and the CLI is now a dependency of all of these optional command.

This is a breaking change and the users will have to do this change on their end if they still want to use version and publish

- "@lerna-lite/cli": "2.0.0",      <-- you could also keep it, it will be installed behind the scene anyway
+ "@lerna-lite/publish": "2.0.0"
+ "@lerna-lite/version": "2.0.0",  <-- you could skip version since it's tightly coupled to the publish pkg

Also note that @lerna-lite/version is a strict dependency of @lerna-lite/publish, so just installing the publish package will automatically provide the version as well. Behind the scene it will install the following

"@lerna-lite/cli": "2.0.0",
"@lerna-lite/publish": "2.0.0"
"@lerna-lite/version": "2.0.0",

Motivation and Context

The issue #450 highlighted the fact that some users, not just in that issue, are actually using only the run and/or exec commands and they're not interested in publish and version commands since they have their own process for publishing releases (or sometime not publishing at all). The new watch command could also be another example of a command that could be used as a standalone without having to install and download version and publish

How Has This Been Tested?

Types of changes

  • Chore (change that has absolutely no effect on users)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2023

Codecov Report

❗ No coverage uploaded for pull request base (next@58c92a2). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next     #552   +/-   ##
=======================================
  Coverage        ?   97.64%           
=======================================
  Files           ?      160           
  Lines           ?    12383           
  Branches        ?     2017           
=======================================
  Hits            ?    12090           
  Misses          ?      292           
  Partials        ?        1           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit 11e4dab into next Apr 6, 2023
@ghiscoding ghiscoding deleted the feat/optional-version-publish branch April 6, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant