Skip to content

fix: all TS Types problems in all unit test spec files & make sure no helpers are published#549

Merged
ghiscoding merged 1 commit intonextfrom
feat/typescript-spec-types
Apr 6, 2023
Merged

fix: all TS Types problems in all unit test spec files & make sure no helpers are published#549
ghiscoding merged 1 commit intonextfrom
feat/typescript-spec-types

Conversation

@ghiscoding
Copy link
Copy Markdown
Member

Description

This PR fixes most TypeScript Types problems in unit test files and also fixes some __tests__ and __helpers__ that were leaking to distribution folders

Motivation and Context

To get full Typing support in VSCode for development and to make sure no test related stuff are being published when it shouldn't (there were some folders that were published but it was only a few files, not that many)

How Has This Been Tested?

Types of changes

  • Chore (change that has absolutely no effect on users)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2023

Codecov Report

❗ No coverage uploaded for pull request base (next@f6a2488). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next     #549   +/-   ##
=======================================
  Coverage        ?   97.64%           
=======================================
  Files           ?      160           
  Lines           ?    12374           
  Branches        ?     2013           
=======================================
  Hits            ?    12081           
  Misses          ?      292           
  Partials        ?        1           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit dfd18e3 into next Apr 6, 2023
@ghiscoding ghiscoding deleted the feat/typescript-spec-types branch April 6, 2023 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant