feat(version): use await import instead of require() for GHE release#546
Merged
ghiscoding merged 1 commit intonextfrom Apr 5, 2023
Merged
feat(version): use await import instead of require() for GHE release#546ghiscoding merged 1 commit intonextfrom
ghiscoding merged 1 commit intonextfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## next #546 +/- ##
=======================================
Coverage ? 97.64%
=======================================
Files ? 160
Lines ? 12374
Branches ? 2012
=======================================
Hits ? 12081
Misses ? 292
Partials ? 1 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use
await import()instead ofrequire()to be fully ESM compatibleMotivation and Context
I tried
createRequirebut that caused issue when I tried it under the conventional commits changelog creation, so I assume it might also give problems when creating GitHub Release with GHE which was loading Oktokit GHE plugin dynamic imports. Usingawait import()is more bullet proof for ESMHow Has This Been Tested?
Types of changes
Checklist: