Skip to content

chore: change all istanbul ignores to c8 ignores#544

Merged
ghiscoding merged 1 commit intonextfrom
chore/istanbul-to-c8-comments
Apr 5, 2023
Merged

chore: change all istanbul ignores to c8 ignores#544
ghiscoding merged 1 commit intonextfrom
chore/istanbul-to-c8-comments

Conversation

@ghiscoding
Copy link
Copy Markdown
Member

Description

Convert all Istanbul ignore comments to c8 ignore comments

Motivation and Context

Since we migrated from Jest to Vitest, we also also use c8 reporter which is better for ESM code, so we need to review all Istanbul ignore comments and use c8 ignore comments instead

How Has This Been Tested?

Types of changes

  • Chore (change that has absolutely no effect on users)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ghiscoding ghiscoding merged commit 9a2f45c into next Apr 5, 2023
@ghiscoding ghiscoding deleted the chore/istanbul-to-c8-comments branch April 5, 2023 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant