Skip to content

feat(publish): remove --require-scripts, keep npm scripts lifecycle#542

Merged
ghiscoding merged 1 commit intonextfrom
feat/remove-require-scripts
Apr 5, 2023
Merged

feat(publish): remove --require-scripts, keep npm scripts lifecycle#542
ghiscoding merged 1 commit intonextfrom
feat/remove-require-scripts

Conversation

@ghiscoding
Copy link
Copy Markdown
Member

Description

Remove old deprecated option --require-scripts, it was only used by Babel when Lerna was originally created a long time ago, it's so old that it wasn't even documented

Motivation and Context

The option --require-scripts have been deprecated for a very long time and using npm scripts have been the preferred approach for many years already, it also follows this Lerna PR 1862

How Has This Been Tested?

Types of changes

  • Chore (change that has absolutely no effect on users)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 5, 2023

Codecov Report

❗ No coverage uploaded for pull request base (next@5506ea5). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next     #542   +/-   ##
=======================================
  Coverage        ?   97.53%           
=======================================
  Files           ?      160           
  Lines           ?    12703           
  Branches        ?     2045           
=======================================
  Hits            ?    12389           
  Misses          ?      313           
  Partials        ?        1           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit 6559aec into next Apr 5, 2023
@ghiscoding ghiscoding deleted the feat/remove-require-scripts branch April 5, 2023 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant