chore(publish): remove deprecated --no-workspace-strict-match option#541
Merged
ghiscoding merged 1 commit intonextfrom Apr 5, 2023
Merged
chore(publish): remove deprecated --no-workspace-strict-match option#541ghiscoding merged 1 commit intonextfrom
--no-workspace-strict-match option#541ghiscoding merged 1 commit intonextfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## next #541 +/- ##
=======================================
Coverage ? 97.54%
=======================================
Files ? 160
Lines ? 12737
Branches ? 2052
=======================================
Hits ? 12423
Misses ? 313
Partials ? 1 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
remove deprecated
--no-workspace-strict-matchoptionMotivation and Context
When we first introduced the
workspace:protocol, it wasn't strict and we soon after introduced the strict mode so that it follows more closely the pnpm/yarnworkspace:protocol. I don't see any user who wouldn't want the script mode so the no strict was deprecated a while back and this PR removes that code and we now only assume strict matchThe strict match will do the following:
{ "dependencies": { "foo": "workspace:*", "bar": "workspace:~", "qar": "workspace:^", "zoo": "workspace:^1.5.0" } }and published as the following strict match
{ "dependencies": { "foo": "1.5.0", "bar": "~1.5.0", "qar": "^1.5.0", "zoo": "^1.5.0" } }the non-strict match, was basically going to publish everything (except foo) as
~1.5.0which is probably not what any user would want.How Has This Been Tested?
Types of changes
Checklist: