chore(version): remove sync lock support for npm version below 8.5.0#540
Merged
ghiscoding merged 2 commits intonextfrom Apr 5, 2023
Merged
chore(version): remove sync lock support for npm version below 8.5.0#540ghiscoding merged 2 commits intonextfrom
ghiscoding merged 2 commits intonextfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #540 +/- ##
==========================================
+ Coverage 97.45% 97.54% +0.10%
==========================================
Files 152 160 +8
Lines 4577 12758 +8181
Branches 1062 2053 +991
==========================================
+ Hits 4460 12444 +7984
- Misses 117 313 +196
- Partials 0 1 +1
... and 48 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove support for npm version below 8.5.0 for the
--sync-workspace-lockoption, the new release will require NPM to be at least 8.5.0 so we can drop old codeMotivation and Context
The code implementation of
--sync-workspace-lockfor NPM below 8.5.0 was achieved in 2 steps instead of 1 step with NPM >=8.5.0, we had tonpm-shrinkwrap.jsonnpm-shrinkwrap.jsonback topackage-lock.jsonbut in >=8.5.0 it's achieved in 1 simple step we can simply run
npm install --package-lock-onlywithout any shrinkwrapHow Has This Been Tested?
Types of changes
Checklist: