chore: use node: imports and fs-extra/esm import#539
Merged
ghiscoding merged 1 commit intonextfrom Apr 4, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## next #539 +/- ##
=======================================
Coverage ? 97.55%
=======================================
Files ? 160
Lines ? 12768
Branches ? 2054
=======================================
Hits ? 12454
Misses ? 313
Partials ? 1 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
NodeJS is now telling us to prefer
import:instead ofdefaultimports for better ESM support, for examplefrom 'fs'should befrom 'node:fs'. We also usefs-extrawhich is giving us hint to usefs-extra/esmfor better ESM support.Motivation and Context
Prefer ESM approach as much as possible for the next major release, this is also part of a breaking change since it requires Node 16 and higher
How Has This Been Tested?
Types of changes
Checklist: