Skip to content

chore: update Vitest snapshot to temporarily proceed with migration#538

Merged
ghiscoding merged 1 commit intonextfrom
chore/vitest-snapshot-bypass
Apr 4, 2023
Merged

chore: update Vitest snapshot to temporarily proceed with migration#538
ghiscoding merged 1 commit intonextfrom
chore/vitest-snapshot-bypass

Conversation

@ghiscoding
Copy link
Copy Markdown
Member

Description

This PR is a quick temporary to an issue with Vitest Snapshot

Motivation and Context

Temporary fix for Vitest Snapshot issue and is a continuation of PR #537, we'll probably have to rollback this PR once the Vitest Snapshot bug is resolved. The snapshots are currently incorrect since they are sometime escaped with single quote and sometime without any quotes. Again this is a temp fix and Vitest will hopefully provide a fix to their snapshots, this temp fix should allow CI to pass

How Has This Been Tested?

ran locally with vitest --update to update Vitest Snapshot

Types of changes

  • Chore (change that has absolutely no effect on users)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 4, 2023

Codecov Report

❗ No coverage uploaded for pull request base (next@308fc2e). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             next     #538   +/-   ##
=======================================
  Coverage        ?   97.55%           
=======================================
  Files           ?      160           
  Lines           ?    12770           
  Branches        ?     2054           
=======================================
  Hits            ?    12456           
  Misses          ?      313           
  Partials        ?        1           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ghiscoding ghiscoding merged commit 41217cc into next Apr 4, 2023
@ghiscoding ghiscoding deleted the chore/vitest-snapshot-bypass branch April 4, 2023 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant