Fix midair collision#604
Conversation
| { args: ["cd " + escapeArgs(path.join(testDir, "packages/package-3")) + " && npm publish --tag lerna-temp", {env: {"npm_config_registry":"https://my-private-registry"}}] }, | ||
| { args: ["cd " + escapeArgs(path.join(testDir, "packages/package-4")) + " && npm publish --tag lerna-temp", {env: {"npm_config_registry":"https://my-private-registry"}}] } | ||
| { args: ["cd " + escapeArgs(path.join(testDir, "packages/package-4")) + " && npm publish --tag lerna-temp", {env: {"npm_config_registry":"https://my-private-registry"}}] }, | ||
| { args: ["cd " + escapeArgs(path.join(testDir, "packages/package-2")) + " && npm publish --tag lerna-temp", {env: {"npm_config_registry":"https://my-private-registry"}}] } |
There was a problem hiding this comment.
:squint: [1,3,4,2]?
Is that a consistent order, or are these just all racing against each other?
There was a problem hiding this comment.
Whelp, the build passed, so... fixed forever! 😁
There was a problem hiding this comment.
I'm p sure its a consistent order. 2 and 4 have a dependency on 1, and 1 and 3 have no dependencies, so there are two batches: [[1,3], [2,4]]. As to whether 1 always goes before 3 and 4 always goes before 2, I'm less certain, but in my ten or so runs they are consistent, and all the ci suites passed, so it seems so?
There was a problem hiding this comment.
That makes sense. Thanks for checking!
|
This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
3 participants
I broke the build 😢. This fixes it. Thanks to @gigabo for catching it