Always run test and env scripts#587
Merged
evocateur merged 3 commits intolerna:masterfrom Feb 16, 2017
Merged
Conversation
Fixes lerna#491 npm defines default scripts for `test` and `env`. Lerna only runs scripts when they’re defined in `package.json`, but this could lead to unexpected behaviour in these two cases. In particular, it could lead to `pretest` and `posttest` not being run by Lerna, when npm would have run them.
Was using `.packages` to try and fix a test, and never undid it.
evocateur
approved these changes
Feb 10, 2017
doug-wade
approved these changes
Feb 16, 2017
|
This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #491
npm defines default scripts for
testandenv. Lerna only runsscripts when they’re defined in
package.json, but this could lead tounexpected behaviour in these two cases. In particular, it could lead
to
pretestandposttestnot being run by Lerna, when npm would haverun them.