Skip to content

[Internal] Normalize trailing slash on failing test by using path.resolve#392

Closed
darrylhodgins wants to merge 12 commits intolerna:config-locationsfrom
darrylhodgins:config-locations
Closed

[Internal] Normalize trailing slash on failing test by using path.resolve#392
darrylhodgins wants to merge 12 commits intolerna:config-locationsfrom
darrylhodgins:config-locations

Conversation

@darrylhodgins
Copy link
Copy Markdown
Contributor

No description provided.

@darrylhodgins
Copy link
Copy Markdown
Contributor Author

Thought that might help, but there's some kind of permissions thing going on with Appveyor. Hmm…

@lukebatchelor
Copy link
Copy Markdown
Contributor

I was getting the same thing but only on 1 of 5 builds. As a workaround, I amended the previous commit and force pushed a couple of times and it worked eventually.

@jamiebuilds
Copy link
Copy Markdown
Contributor

bclinkinbeard and others added 3 commits November 16, 2016 11:41
… package.json (lerna#393)

* Expect packages config to be an array of glob patterns to directories containing package.json

* Mention packages config in README

* Attempt to avoid test failures on Appveyor
@jamiebuilds jamiebuilds changed the title Normalize trailing slash on failing test by using path.resolve [Internal] Normalize trailing slash on failing test by using path.resolve Nov 16, 2016
@jamiebuilds
Copy link
Copy Markdown
Contributor

jamiebuilds commented Nov 16, 2016

I'm sorry dude... I don't know what is happening in AppVeyor.

@gigabo gigabo force-pushed the config-locations branch 7 times, most recently from 1c76b71 to af4a738 Compare December 14, 2016 19:50
@evocateur
Copy link
Copy Markdown
Member

I'm pretty sure we already have most, if not all of the changes from this PR.

@evocateur evocateur closed this Mar 17, 2017
@darrylhodgins darrylhodgins deleted the config-locations branch August 7, 2017 14:20
@lock
Copy link
Copy Markdown

lock Bot commented Dec 27, 2018

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Dec 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants