[Feature] Add support for configurable package locations#365
Conversation
| "version": "1.0.0", | ||
| "packages": [ | ||
| {"glob": "packages/*/package.json"}, | ||
| {"glob": "package-3/package.json"} |
There was a problem hiding this comment.
I would think that glob would be the name of a package here, but it looks like it globs paths to find a package.json
There was a problem hiding this comment.
Yeah that makes more sense as an API
There was a problem hiding this comment.
Why is a complex object even used here? An array of globs would be perfect.
There was a problem hiding this comment.
I don't know...
There was a problem hiding this comment.
I just submitted #393 which changes packages to an array of globs and does not require package.json to be specified, since I think that can be assumed. I also added a basic explanation to the README.
There was a problem hiding this comment.
The tests in #393 pass locally and on Travis, so I'm assuming the Appveyor failures are on their end. Is there anything else I can do to improve the PR?
There was a problem hiding this comment.
@bclinkinbeard, you might find that #392 "helps" with one of the Appveyor failures (makes the test a little less platform-dependent).
There was a problem hiding this comment.
Thanks @darrylhodgins, I just pushed that up. :fingers-crossed:
There was a problem hiding this comment.
@bclinkinbeard, I should have clarified: #392 doesn't solve the Appveyor permissions problem, just the path on that one test…
|
No pressure but having this sooner would be nice :) |
|
I've added #392 yesterday to work around a unit test that was failing (but there seem to be permissions errors on AppVeyor). |
jamiebuilds
changed the title
|
Hey All, any plans for when this will be merged in? |
|
I really wanted this feature so I published this branch to npm here: @ahfarmer/lerna. For those not familiar with scoped packages, the |
|
Okay, let's see if we can get this thing into shape and out the door. The AppVeyor failures look real. I remember when we did this on Asini we had to make some tweaks to tests to get it working on Windows. Might just be a matter of adding some @rygine Does that sound right? Or was there also an actual code change we did? |
gigabo
force-pushed
the
config-locations
branch
7 times, most recently
from
c9a0e71 to
1c76b71
Compare
This adds a `packages` configuration option to `lerna.json`:
```json
{
"lerna": "x.x.x",
"version": "0.2.3",
"packages": [
{"glob": "packages/{core,plugins}/*/package.json"},
{"glob": "build-tools/package.json"},
{"glob": "integration-tests/**/package.json"}
]
}
```
The default is `[{"glob": "packages/*/package.json"}]`, which is equivalent to
the historical layout of a Lerna repo.
… package.json (#393) * Expect packages config to be an array of glob patterns to directories containing package.json * Mention packages config in README * Attempt to avoid test failures on Appveyor
gigabo
force-pushed
the
config-locations
branch
from
1c76b71 to
af4a738
Compare
|
Looks like the tests had just somehow gotten weird when this was reopened from #332. I swapped out the first commit for a modified asini/asini#1, and added a commit at the end to deal with tests that changed while this PR was in-flight. Will merge this non-squash to preserve attribution for the contributions from @rygine and @bclinkinbeard. This wound up with a nicer API than it started with. Thanks everyone! |
|
Just wanted to say I've switched back from our fork after this dropped and it's working great! Thanks for all the hard work guys, this project really makes a difference in the way we work. |
|
This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
10 participants
Just needs documentation. @nruhe you said you were interested? I would now, but I'm working on documentation for another project about to be open sourced