Add gitlab releases to version#2073
Merged
evocateur merged 1 commit intoJun 9, 2019
Merged
Conversation
lbennett-stacki
commented
May 6, 2019
lbennett-stacki
commented
May 6, 2019
lbennett-stacki
changed the title
evocateur
suggested changes
May 11, 2019
evocateur
left a comment
evocateur
left a comment
Member
There was a problem hiding this comment.
A good start, and I believe this has great promise. Thanks for your patience!
lbennett-stacki
force-pushed
the
add-gitlab-releases-to-version
branch
from
May 12, 2019 05:01
bba7c70 to
14f3237
Compare
lbennett-stacki
commented
May 12, 2019
lbennett-stacki
commented
May 12, 2019
evocateur
suggested changes
May 13, 2019
evocateur
left a comment
evocateur
left a comment
Member
There was a problem hiding this comment.
Good progress, thanks for sticking with it!
lbennett-stacki
force-pushed
the
add-gitlab-releases-to-version
branch
2 times, most recently
from
May 25, 2019 03:56
73812f0 to
78a3764
Compare
Deprecates --github-release, replacing with --create-release. Add GitLabClient with createRelease method, and OctokitAdapter to expose through an octokit interface. Add createRelease factory function to DRY GitHub/GitLab releases.
lbennett-stacki
force-pushed
the
add-gitlab-releases-to-version
branch
from
May 25, 2019 04:34
78a3764 to
bba2d33
Compare
lbennett-stacki
changed the title
Contributor
Author
|
@evocateur ready for another pass :) Thanks for your help so far. |
|
🎉 This looks so amazing thanks for doing this @LukeeeeBennett I had seen this feature and made the request and hadn't yet found the time to try this. |
wldcordeiro
reviewed
May 31, 2019
evocateur
approved these changes
Jun 9, 2019
evocateur
left a comment
evocateur
left a comment
Member
There was a problem hiding this comment.
Awesome, thanks for your patience!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
version --github-releasein favour ofversion --create-release=[gitlab|github].GitLabClientw/createReleasesmethod to create releases using GitLab API.createReleasefunction to DRY GitLab and GitHub releases.Description
I think it's pretty much all there. Let me know if you need any more info.
Links
https://docs.gitlab.com/ee/user/project/releases/index.html
https://docs.gitlab.com/ee/api/releases/index.html
Screenshot
Motivation and Context
I use https://gitlab.com and self-hosted GitLab instances to host my favouritestest repos. I would like the releases feature to work for them.
How Has This Been Tested?
There are tests for deprecation,
GitLabClientand--create-release=gitlab. (--create-release=githubis tested in existing--github-releasetests)Tested locally with:
Types of changes
Note:
--github-releasehas been appropriately deprecated.Checklist: