Refactor publish command to be 98% async#1261
Merged
Merged
Conversation
evocateur
changed the title
evocateur
force-pushed
the
publish-performance
branch
2 times, most recently
from
47bf30e to
0c6028c
Compare
- Use programmatic (async) conventional-commits APIs -- allows preset for recommended bump, woo - Literally every callback except the superclass lifecycle replaced with Promise-based patterns. - Integration test now actually tests --conventional-commits completely, shaving off a few seconds of execution time on average.
evocateur
force-pushed
the
publish-performance
branch
from
0c6028c to
59950d2
Compare
evocateur
commented
Feb 13, 2018
|
|
||
| All notable changes to this project will be documented in this file. | ||
| See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.`); | ||
| function getChangelogConfig(changelogPreset = "conventional-changelog-angular") { |
Member
Author
There was a problem hiding this comment.
We could just let conventional-changelog-preset-loader do the dirty work, but then we wouldn't get caching and more flexibility with scopes and such.
|
This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds on #1260, utilizing the new
Map-and-Set-basedPackageGraphidioms. In the process, some algorithms were dramatically simplified, and performance improved noticeably (especially in the integration tests).PublishCommand--conventional-commitscompletely, shaving off a few seconds of execution time on average.ConventionalCommitUtilitiesconventional-commitsAPIs instead of synchronous CLI calls.conventional-recommended-bump, as long as they support the new preset API.conventional-commits-angular) is included as a dependency, anything custom will need to be installed by the consumer.