This repository was archived by the owner on Jun 18, 2023. It is now read-only.
Merged
Conversation
Setting the proxy to environment variables, since the PySmartDL module does not support it.
Owner
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following issue #31, added support for a proxy argument, similar to pip's one (using --proxy on the CLI). The proxy is added to the environment variables, since PySmartDL does not support it, but uses urllib, which ultimately accepts the env vars.
Since build_cache does not use PySmartDL, but _download does, behaviour differs with the command entered, and so does the environment variable used by the request. Hence, the same proxy is set for different variable names.