Add a simple Bazel module and build file.#79
Merged
lemire merged 1 commit intolemire:masterfrom Oct 31, 2024
Merged
Conversation
Owner
|
Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi authors of fast_double_parser,
I recently ported this excellent library to the Bazel Central Registry. Originated from Google's internal tools, Bazel is an open-source build tool adopted by many companies in the industry as well as open source projects. With Bazel, users can simply import this library by defining in their project
MODULE.bazel:Bazel Central Registry: https://registry.bazel.build/modules/fast_double_parser
Although the build rules are added into the repository of the Bazel Central Registry here, it would be still a great idea to upstream the change to the original repository.
As you can see, the build rule is really simple, so it shouldn't add much maintenance cost to this project. With this patch, you can also run
bazel test //:unitto run the unit test. If you are interested, I can also help add build rules for the benchmark.Best regards,
Carbo