Change vi-mode to a global minor mode to make its keybinds' priority high#992
Closed
fukamachi wants to merge 2 commits intolem-project:mainfrom
Closed
Change vi-mode to a global minor mode to make its keybinds' priority high#992fukamachi wants to merge 2 commits intolem-project:mainfrom
fukamachi wants to merge 2 commits intolem-project:mainfrom
Conversation
Collaborator
Author
|
This resolves most cases of keybinding, but it is not perfect. For example, vi-mode's keymap precedes directory-mode's, so While Lem doesn't have as many layers as Emacs, such as buffer-local keymaps, this kind of problem remains. |
Collaborator
Author
|
Buffer-local keymap and buffer-created hook are required to change keybindings for each mode flexibly. |
Collaborator
Author
|
Without them, it can be achieved by overwriting (defmethod execute ((mode directory-mode) (command vi-return) uarg)
(declare (ignore uarg))
(directory-mode-find-file))However, |
This was referenced Aug 25, 2023
Collaborator
Author
|
Will be fixed in a different way at #1008. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes that
Returnadds a newline even in NORMAL mode with lisp-mode.