Fix vi-mode's word-related motions#969
Merged
cxxxr merged 7 commits intolem-project:mainfrom Aug 20, 2023
Merged
Conversation
cxxxr
reviewed
Aug 20, 2023
extensions/vi-mode/word.lisp
Outdated
| (t :word)))) | ||
|
|
||
| (defun forward-word-begin (char-type-fn &optional (point (current-point))) | ||
| (symbol-macrolet ((point-char (character-at point))) |
Member
There was a problem hiding this comment.
This is a very cool way to write, but I am concerned that others will see this and copy it elsewhere.
What about using labels/flet?
Collaborator
Author
There was a problem hiding this comment.
Okay, I replaced them with simple flets.
Actually, they didn't need symbol macros, I don't know I wrote them with it.
Member
|
Thank you so much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix vi-mode's word-related motions, like
e,E,w,W,bandB.The characters consist of
wordis determined by theiskeywordoption, added by #966.