Merged
Conversation
cxxxr
approved these changes
Jul 19, 2023
Member
cxxxr
left a comment
cxxxr
left a comment
There was a problem hiding this comment.
Thank you for the PR.
I've left a comment, please merge it after you check it out.
modes/lisp-mode/lisp-mode.lisp
Outdated
| (buffer (make-buffer "*lisp-dissasemble*"))) | ||
|
|
||
| (with-pop-up-typeout-window (s buffer :erase t) | ||
| (format s (%lisp-disassemble name))))) |
Member
There was a problem hiding this comment.
Would a ~ in the return value of %lisp-disassemble cause unexpected behavior?
Member
Author
There was a problem hiding this comment.
Oh indeed, I didn't realize, thanks, I think it should be fixed now 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple command that display the disassembly information about the symbol at point, I was thinking of using a major mode to syntax highlight the assembly code, but that's not standard, and some distributions may even have a different representation,
So, the idea on the future is to extend this command and let each implementation to specialize on it.