Make lsp-restart-server proceed even when buffer-workspace fails#1447
Merged
cxxxr merged 1 commit intolem-project:mainfrom Jul 19, 2024
anlsh:main
Merged
Make lsp-restart-server proceed even when buffer-workspace fails#1447cxxxr merged 1 commit intolem-project:mainfrom anlsh:main
cxxxr merged 1 commit intolem-project:mainfrom
anlsh:main
Conversation
I'm using this locally because my LSP server is refusing to come up, and I'm trying to debug/work through the problem by doing `lsp-restart-server`s. However, those fail while deleting the workspace for the current buffer because... it always fails: there's no server to *re*start. Anyways, I *think* this actually makes sense as a general change: I'm not an expert in lem LSP internals so maybe there's some reason this can't be upstream, but to me `lsp-restart-server` should start a connection without erroring if there's no existing one
anlsh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using this locally because my LSP server is refusing to come up, and I'm trying to debug/work through the problem by doing
lsp-restart-servers.However, those fail while deleting the workspace for the current buffer because... lsp initialization always fails, hence the
(buffer-workspace)call always failsAnyways, I think this actually makes sense as a general change: I'm not an expert in lem LSP internals so maybe there's some reason this can't be upstream, but to me
lsp-restart-servershould start a connection without erroring if there's no existing one