Vindarel/legit common less packages better separation#1445
Merged
vindarel merged 2 commits intolem-project:mainfrom Jul 17, 2024
Merged
Conversation
with-porcelain-error and with-current-project belong to lem/legit to avoid tight coupling between the porcelain package and Lem. We add them to a file common to peek-legit and legit. We also delete the peek-legit package to simplify everything.
cxxxr
approved these changes
Jul 17, 2024
vindarel
deleted the
vindarel/legit-common-less-packages-better-separation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with-porcelain-errorandwith-current-projectbelong to lem/legit to avoid tight coupling between the porcelain package and Lem, which is very important to me for both ease of development and better engineering (porcelain being independent could be used elsewhere, who knows). Actually the previous commit re-introduced the tight coupling, so here we are back to normal.We add them to a file common to peek-legit and legit.
We also delete the peek-legit package to simplify everything, as peek-legit and legit were very tightly coupled anyways. This simplifies calling symbols from one package or another and it removes the need of dealing with so many exports.