Merged
Conversation
Contributor
davidsun0
commented
Jun 13, 2024
davidsun0
commented
- Fix issue where commands like y% were interpreted as y1% (vi-mode: commands with % movement select the wrong text #1402)
- Add regression tests
- Fix issue where commands like y% were interpreted as y1% - Add regression tests
Member
|
Thank you. |
Contributor
Author
|
The failing test is for vi macros, but the test doesn't use %, so I don't think it's caused by my changes. I'll try debugging it and see what I find. |
Member
|
I'm sorry to have merged without waiting for CI, but it seems that I've started to fail with this PR. |
- Specify that only 'dd' deletes trailing blank line - Add regression test for delete with motion on trailing blank line
Contributor
Author
|
@cxxxr Thanks for waiting. I fixed my mistake and improved the |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.