Skip to content

Comments

Fallback to asdf:load-system to create a micros server#1385

Merged
cxxxr merged 2 commits intolem-project:mainfrom
garlic0x1:micros-no-ql
May 29, 2024
Merged

Fallback to asdf:load-system to create a micros server#1385
cxxxr merged 2 commits intolem-project:mainfrom
garlic0x1:micros-no-ql

Conversation

@garlic0x1
Copy link
Collaborator

the function send-swank-create-server assumes the user has quicklisp installed and fails if they don't.

I have replaced

 "(ql:quickload :micros)"

with

   "(handler-case (eval (read-from-string \"(ql:quickload :micros)\"))
      (error (c) (asdf:load-system :micros)))"

so that it falls back to asdf:load-system if quicklisp is not available.

Catching a reader error like this is a bit hacky, maybe we should just always use asdf:load-system? I'm not sure, but this seems to work.

Also, auto-formatting.

@cxxxr cxxxr merged commit 7f73ab5 into lem-project:main May 29, 2024
@cxxxr
Copy link
Member

cxxxr commented May 29, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants