Make define-command accept more verbose/understandable argument-descriptors#1375
Merged
cxxxr merged 3 commits intolem-project:mainfrom May 25, 2024
Merged
Make define-command accept more verbose/understandable argument-descriptors#1375cxxxr merged 3 commits intolem-project:mainfrom
cxxxr merged 3 commits intolem-project:mainfrom
Conversation
added 2 commits
May 24, 2024 20:26
Member
|
I think it's very nice. By the way, I would like to avoid preparing num, what do you think? |
Contributor
Author
|
I agree. If people want to type less they can still use the string-descriptors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A comment on discord mentioned that strings as argument-descriptors are sub optimal, to which I agree.
This merge-request overhauls the
define-commandmacro so that it accepts both old-style string descriptors, as well as list argument-descriptors.The following descriptors were added:
:universal,:universal-1,:universal-nil,:string,:number,:num,:buffer,:other-buffer,:file,:new-fileand:regionwith
:universal-1andbeing aliases of:num:universalandrespectively.:numberI also added some documentation to the existing
:splicedescriptor and exposed the extremely helpful comment in the command-function as a doc-string.