Skip to content

Comments

Add ignore-all-space option in legit#1368

Merged
cxxxr merged 2 commits intomainfrom
legit-ignore-all-space
May 21, 2024
Merged

Add ignore-all-space option in legit#1368
cxxxr merged 2 commits intomainfrom
legit-ignore-all-space

Conversation

@cxxxr
Copy link
Member

@cxxxr cxxxr commented May 20, 2024

No description provided.

@cxxxr cxxxr requested a review from vindarel May 20, 2024 17:43
"If non nil, print some logs on standard output (terminal) and create the hunk patch file on disk at (lem home)/lem-hunk-latest.patch.")

(defvar *ignore-all-space* t)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would love a docstring ;)

The name is nearly perfectly self-explanatory, but maybe not for everybody. Also, it will be helpful for the future auto-generated user documentation.

Proposal:

"If non t, show all spaces in a diff. Spaces are ignored by default.

Currently Git-only. Concretely, this calls Git with the -w option."

Thanks for the ping, I appreciate to follow the changes in Legit.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the your review.
I added that docstring.

@cxxxr cxxxr requested a review from vindarel May 21, 2024 11:39
@cxxxr cxxxr merged commit 60a8d57 into main May 21, 2024
@vindarel vindarel deleted the legit-ignore-all-space branch May 21, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants