Merged
Conversation
The qlot image installs as root, making the resultant image only runnable as root (which is bad in the first place). Also prefer alpine for a smaller image size (200MB smaller) We also combine the two build & install commands so the build only runs if the install completes.
Build and push the image to the Github Container Registry, allowing users to just pull the image without building.
cxxxr
reviewed
Mar 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nothing earth-shattering here, changes documented in the commits but I'll summarize here as well as provide the necessary post-merge setup
Clean up image
The qlot image that this is based on installs qlot to the root user only, which breaks when trying to run the container as a user other than root. The reason for alpine is it produces a smaller image (200MB smaller) and otherwise runs just fine. Happy to revert this commit if needed, the main reason for the PR is the second point
Add support for GHCR
Since it's free, might as well take advantage of hosting an image on github so that users don't have to build their own and deal with the issues associated (like #1271). You can see the result of the build on my fork and the only bit of post-merge setup is go to here and change the below setting to reflect the image
Also not sure exactly what logic should determine what triggers a new image deployment, currently it'll run regardless of the CI building/failing but I can have it linked to that if needed; though it seems to be failing...
And to show that it works
If preferred, I can also look into pushing to docker hub instead; but I don't think there's much point outside of saving having to type
ghcr.io/.Thanks all!