[Merged by Bors] - refactor: use the new homology API for the four and the five lemmas#9022
Closed
[Merged by Bors] - refactor: use the new homology API for the four and the five lemmas#9022
Conversation
11 tasks
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
TwoFX
reviewed
Dec 14, 2023
joelriou
added
awaiting-author
joelriou
added
awaiting-review
and removed
awaiting-author
Member
riccardobrasca
left a comment
riccardobrasca
left a comment
There was a problem hiding this comment.
Very nice refactor, thanks!
bors merge
ghost
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Dec 21, 2023
…9022) This PR refactors the four and the five lemmas so as to use the new homology API. The files `Algebra.Homology.ShortExact.Abelian` and `Algebra.Homology.ShortExact.Preadditive` are also removed because the content of these files has become redundant with the new homology API. Co-authored-by: Joël Riou <[email protected]>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the four and the five lemmas so as to use the new homology API. The files
Algebra.Homology.ShortExact.AbelianandAlgebra.Homology.ShortExact.Preadditiveare also removed because the content of these files has become redundant with the new homology API.